@gravitystorm commented on this pull request.
> @@ -17,6 +17,9 @@ FileUtils.chdir APP_ROOT do
puts "== Installing dependencies =="
system("bundle check") || system!("bundle install")
+ # Install JavaScript dependencies
+ system("yarn install --check-files")
+
I'm happy to align with upstream. My main concern, by far, is to make sure that
what is written in the install notes (including any options) is as close to
possible as what is done in CI. We've had so many cases over the years where
the install notes don't work, and we haven't noticed because CI was doing
something subtly different, and who knows how many people tried and failed
before anyone contacted us.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6432#discussion_r2416357045
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6432/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
