gravitystorm left a comment (openstreetmap/openstreetmap-website#6478)
It's a shame that we have to follow the minimum node version from a package
that we only need static `.json` files from! It would be great to have as wide
a supported version as possible, so that devs can use distribution packages
wherever possible.
Given that [we use
bookworm](https://github.com/openstreetmap/openstreetmap-website/blob/5fdeb3c68a906094f5ad5e0e722f5b81ad871d02/Dockerfile#L2)
in the Dockerfile, and [bookworm ships with node
18](https://packages.debian.org/bookworm/nodejs), this change would be expected
to fail CI.
However, since [we've patched bin/yarn to use
`--ignore-engines`](https://github.com/openstreetmap/openstreetmap-website/blob/master/bin/yarn#L13)
it still works. This then leads to a confusing situation where we will both
specify a minimum node version (22) and also go out of our way to ignore it,
and I'm not sure that's ideal.
Any thoughts? Is there any trickery that can allow us to set a minimum node
version (so that dependabot doesn't unexpectedly introduce a new stricter
minimum) while also allow per-package overrides (e.g. for packages where we
don't execute any javascript code)?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6478#issuecomment-3451542098
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6478/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
