pablobm created an issue (openstreetmap/openstreetmap-website#6495)
Currently, the UI for map notes is built with a JS widget that accesses the API
directly.
This is difficult to maintain, as it deviates from Rails conventions and
requires a higher grade of JS skills in addition to the default Rails skills.
It also creates issues where some app errors are not translated (see
https://github.com/openstreetmap/openstreetmap-website/issues/6367) or errors
coming from elsewhere in the infrastructure are rendered badly (see
https://github.com/openstreetmap/openstreetmap-website/issues/6422).
This issue proposes that the notes UI is refactored to use Hotwire, which would
address these issues.
Ideally this would be done in several steps rather than a single big PR. On
first approach, it looks like the code to add note comments
(`app/assets/javascripts/index/note.js`) can be refactored separately from the
code to create comments (`app/assets/javascripts/index/new_note.js`). Therefore
these could be two separate PRs. Other PRs could be added to provide refactors
along the way, if appropriate.
### Potential conflicts
The following open PRs intend to make changes to the data model for notes.
Therefore they might create conflicts with PRs derived from this issue:
- https://github.com/openstreetmap/openstreetmap-website/pull/5815
- https://github.com/openstreetmap/openstreetmap-website/pull/5904
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6495
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/issues/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
