gravitystorm left a comment (openstreetmap/openstreetmap-website#6497)
I'd be happy to see the tests updated to use rack-test by default, and a full
browser only when needed for full javascript execution. I don't think there's
any noticeable gap between the html generation of rack-test and a browser,
whereas there were often issues back in the poltergeist-vs-real-browser days
for JS execution.
For me, the "visit link" style testing is the most important bit. I'd prefer if
the controller-style and integration-style tests were all rewritten away from
raw POSTs etc (apart from the tests that deliberately try to inject incorrect
form submissions to validate the error handling) but that's such a huge project
I've never thought it was worthwhile.
I'm used to using rspec in other projects, and only tagging the specific system
tests that need javascript with an option, e.g. `it "does something", :js do`.
I don't know if there's a way to do similar tagging with minitest, or whether
trying to do that becomes more complex (especially for novice developers) than
it's worth.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6497#issuecomment-3484923802
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6497/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
