@hlfan commented on this pull request.
> <span class="visually-hidden"><%= t ".title_label" %></span>
<%= link_to entry.title, diary_entry_path(@user, entry), :class
=> "align-self-center lh-sm" %>
</p>
<p class="card-text flex-grow-1"><%=
truncate(strip_tags(entry.body.to_html), :length => 150) %></p>
<div class="card-text d-flex justify-content-between
align-items-center mt-auto">
<small class="text-body-secondary d-flex gap-1
align-items-center">
- <i class="bi bi-chat fs-5 my-n1" aria-hidden="true"></i>
+ <i class="bi bi-chat fs-5 my-n1" title="<%= t
".comments_label" %>" aria-hidden="true"></i>
It only occurred to me once I was testing something else on
https://master.apis.dev.openstreetmap.org/ that the hover tooltips need a title
attribute.
And since the Bootstrap icons use special characters in the pseudo-elements,
I'm not happy with having this maybe appear on screen readers.
Hence twice.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6501#discussion_r2498993240
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6501/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
