@pablobm commented on this pull request.
Looks like we can finally move this forward! 🚀 @kcne - Would you be able to
rebase? There have been significant changes to the user profile page since this
PR was created, so it will need some rework. Also I have left a comment about
the data model.
> @@ -0,0 +1,5 @@
+class AddShowContributionHeatmapToUsers < ActiveRecord::Migration[7.2]
+ def change
+ add_column :users, :show_contribution_heatmap, :boolean, :default => true,
:null => false
Two questions on this one:
- How about using the existing user preferences instead of a new column?
- If we proceed like this: it ok to create a column with a default value in a
large table? My recollection is that the column may take some time to fill out,
perhaps even locking the table. I can't be sure though. Perhaps @Firefishy can
refresh my memory?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5853#pullrequestreview-3429484789
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5853/review/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
