@tomhughes commented on this pull request.

I wonder if we should be cancelling any fetch that is still running when the 
history panel is closed?

> @@ -269,7 +271,7 @@ OSM.History = function (map) {
     changesetsLayer.updateChangesetsGeometry(map);
   }
 
-  function updateMap() {
+  function updateMap(isHistory = false) {

We don't really need a default here because both callers have been changed to 
pass the argument.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6520#pullrequestreview-3449224613
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/6520/review/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to