@tomhughes commented on this pull request.


> +      link_size = 0
+
+      doc = Nokogiri::HTML(text.to_html)
+
+      if doc.content.empty?
+        link_proportion = 0
+      else
+        doc.xpath("//a").each do |link|
+          link_count += 1
+          link_size += link.content.length
+        end
+
+        link_proportion = link_size.to_f / doc.content.length
+      end
+
+      downcased_content = doc.content.downcase

Really you should use the unicode case folding transformation if you want to do 
case insensitive comparison rather than using upcase or downcase but it doesn't 
look like ruby has that as a standard string method :disappointed: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6549#discussion_r2561175486
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/6549/review/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to