@tomhughes requested changes on this pull request.
This needs to add `tile.openstreetmap.org` to the `connect_src` rule in
`config/initializers/content_security_policy.rb` as maplibre-gl fetches the
tiles with XHR rather than as images.
Personally I'd suggest removing the 1 pixel border between controls in a group
so the the zoom in/out don't have a gap between them like the current map but
I'm open to argument on that.
Whether to put the geolocate control in the same group (if that's even
possible?) is a more interesting question - it looks OK separate here but it
might become more of an issue when we get to the main page where there are more
controls?
Finally, could we tone down the colour of the marker a bit? To get it a bit
closer to the current one - it's not so much that I want it to be identical but
the new one is very bright and a bit in your face?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6504#pullrequestreview-3521247827
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6504/review/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
