@tomhughes commented on this pull request.
As fast as I can tell the icon related changes seem fine though it would have
been helpful to have a bit more information about what you were doing as the
linked issue is only about the menu.
The menu change does fix the current issues in dark mode, but the result has
very little contrast between the background and the highlight, at least on this
laptop, and the contrast in light mode is also reduced to the point where you
can hardly see the bar.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6576#pullrequestreview-3531693881
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6576/review/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev