pablobm created an issue (openstreetmap/openstreetmap-website#6592)
It's common for PR reviewers to request that commits be squashed into a cleaner
form, eliminating fixup commits and presenting a more consistent history.
However this is not that clear in the contribution guidelines at
[CONTRIBUTING.md](https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md)
For example, the advice to «[a]void including "fixup" commits» only appears
under a section about "large pull requests", failing to make it clear that is
should apply to others.
Also a pet peeve of mine: I would add advice for contributors not to work on
`master` for their changes. Might as well include it in the guidelines too.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6592
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/issues/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
