pablobm left a comment (openstreetmap/openstreetmap-website#6564)
Ready for a new review:
- Moved the "undelete" action out of users/lists, back to users/show, as
requested by @tomhughes.
- Added a test for "unhide" (first commit, before renaming to "undelete") as it
was missing before.
- Renamed `hide` as `mark_deleted` in the code, which is more descriptive.
Question: if this PR is merged, the status transition `mark_deleted` will have
no production use left. It'll be there only for the benefit of some tests that
I don't think would represent reality either. Should transition and tests be
removed altogether?
CI error appears to be a flaky test (see
https://github.com/openstreetmap/openstreetmap-website/actions/runs/20302680370/job/58311962725?pr=6564).
Rerunning
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6564#issuecomment-3665153127
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6564/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
