@HolgerJeromin commented on this pull request.
> + tiles: expandedUrls,
+ tileSize: 256,
+ maxzoom: maxzoom
+ }
+ },
+ layers: [
+ {
+ id: "raster",
+ type: "raster",
+ source: "raster"
+ }
+ ]
+ };
+};
+
+OSM.MapLibre.Styles.Mapnik = () => createRasterStyle(19,
"https://tile.openstreetmap.org/{z}/{x}/{y}.png");
I find the usage super surprising
```js
const style = OSM.MapLibre.Styles[styleId](layer.options);
```
Perhaps we should rename it
```js
const style = OSM.MapLibre.createStyles[styleId](layer.options);
```
Or make a helper
```js
const style = OSM.MapLibre.createStyles(styleId, layer.options);
```
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6683#pullrequestreview-3648710982
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6683/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev