@SykoDaedalus commented on this pull request.
> @@ -80,11 +80,20 @@
}
})
});
+ const demoQuery = new URLSearchParams({ profile: DEMO_PARAMS[modeId]
});
> Then I'd rather add this config to the `OSM.Directions.addEngine` lines than
> having a separate dict in different places.
Valhalla and osrm will then need 3 params in addEngine function while
graphhopper we can work with vehicleType (the existing 2 params). Should I
change it to 3 params for all of them (to maintain consistency) or only in 2
where we need it?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6693#discussion_r2683425871
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6693/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
