@hlfan commented on this pull request.
> @@ -5,7 +5,7 @@
<fieldset>
<legend><%= t ".location" -%></legend>
- <%= render :partial => "layouts/control_icons", :locals => { :icons =>
%w[zoomin zoomout] } %>
+ <%= render :partial => "layouts/control_icons", :locals => { :icons =>
%w[plus-lg dash-lg] } %>
Why are you calling the deleted partial?
> @@ -82,7 +82,7 @@ class SiteTest < ApplicationSystemTestCase
find_field("Map Notes").hover # try to trigger disabled tooltip
end
within "#map" do
- zoom_out = find_link("Zoom Out")
+ zoom_out = find(".leaflet-control-zoom-out")
Why was this changed?
> .attr("title", OSM.i18n.t("javascripts.site.queryfeature_tooltip"))
.appendTo($container);
- $(L.SVG.create("svg"))
- .append($(L.SVG.create("use")).attr("href", "#icon-query"))
- .attr("class", "h-100 w-100")
- .appendTo(link);
+ link.append($("<i>").addClass("bi bi-question-lg"));
Can this be moved to before the link is added to the container?
```suggestion
.attr("title", OSM.i18n.t("javascripts.site.queryfeature_tooltip"))
.append($("<i>").addClass("bi bi-question-lg"));
.appendTo($container);
```
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6695#pullrequestreview-3652261152
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6695/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
