Switching from custom SVGs to Bootstrap icons removes the inconsistency of logo sizes in the buttons:
<img src="https://github.com/user-attachments/assets/d8f7d78b-6872-4477-a668-079ad7c2b2ec" /> <img src="https://github.com/user-attachments/assets/9b37771e-7489-4e90-be9a-8c242280f1d1" /> Also, this quite considerably slims the codebase. The `SHARE_BUTTONS_CONFIG` could be put in a YAML file in another PR if requested. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6738 -- Commit Summary -- * Make share buttons use Bootstrap icons -- File Changes -- D app/assets/images/share_button_icons/bluesky.svg (5) D app/assets/images/share_button_icons/email.svg (4) D app/assets/images/share_button_icons/facebook.svg (4) D app/assets/images/share_button_icons/linkedin.svg (4) D app/assets/images/share_button_icons/mastodon.svg (5) D app/assets/images/share_button_icons/share.svg (3) D app/assets/images/share_button_icons/telegram.svg (16) D app/assets/images/share_button_icons/x.svg (1) M app/assets/javascripts/share_buttons.js (5) M app/assets/stylesheets/common.scss (6) M app/helpers/share_buttons_helper.rb (78) M test/helpers/share_buttons_helper_test.rb (17) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/6738.patch https://github.com/openstreetmap/openstreetmap-website/pull/6738.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6738 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/[email protected]>
_______________________________________________ rails-dev mailing list [email protected] https://lists.openstreetmap.org/listinfo/rails-dev
