dheeraj12347 left a comment (openstreetmap/openstreetmap-website#6743)
> ... and it's using hardcoded strings, not even vaguely using the i18n system.
>
> @dheeraj12347 I'm going to close this PR. If you want to try again, please
> review your own pull request carefully before submitting it for review.
> Submitting a PR that an AI wrote for you without proof-reading it (and not
> even copy+pasting it carefully) is just wasting the time of other volunteers.
Thanks for the review and for pointing out the problems.
You’re right – I used an AI suggestion without checking it carefully, which
caused the prompt to be pasted into the file and added a lot of unrelated
whitespace and hard‑coded strings.
I’ve now redone the change manually, removed all unrelated edits, and used the
existing i18n system for the contributor text. I will open a new PR with the
corrected changes and will review it myself before submitting.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6743#issuecomment-3808869249
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6743/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
