@1ec5 commented on this pull request.
> +
+ $(document).on("click", "a.edit_object_tags", async function (e) {
+ e.preventDefault();
+ e.stopPropagation();
+
+ e.target.setAttribute("disabled", true);
+
+ const [, type, id] =
location.pathname.match(/\/(node|way|relation)\/([0-9]+)/);
+ const objectInfo = await downloadObjectInfo(type, id);
+ const currentTags = extractTagsFromObjectInfo(objectInfo);
+
+ const $browseSection = $("#sidebar_content h2 + div").first();
+
+ const $errorBox = $("<p>");
+
+ const $editorTextarea = $("<textarea>")
> A wider field. There are no additional buttons, and the keys column does not
> take up a fixed width
Yeah, the sidebar width can be constraining since it isn’t resizable: #1254.
> Works arrow navigation on the keyboard
Personally I am worried that, the third time I use this feature, I’m going to
press the adjacent <kbd>↑</kbd> and <kbd>⇧</kbd> buttons on my laptop keyboard
and eject a tag by accident. But I probably should be more worried about
what’ll happen when I use this editor on my phone, since you mentioned that as
a motivating factor. MediaWiki presents mobile users with an extra mandatory
preview due to all the possible accidents that can occur, like accidentally
tapping on the Save button while trying to select text. Maybe that confirmation
screen isn’t such a bad idea after all.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6758#discussion_r2743953773
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6758/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
