1ec5 left a comment (openstreetmap/openstreetmap-website#6764)
For future reference, the text in the PR description reads like a rebuttal or
retort. It wasn’t clear who you were responding to, so it took on a more
aggressive tone than you probably intended. In general, it is a good idea to
explain how your PR differs from previous proposals, keeping the focus on the
code and your thought process. You could clarify that the PR doesn’t add
metadata and you don’t think it’s necessary for this part of the fix. Also, you
could also point out that this PR avoids using literal hashtags, as suggested
by the maintainers in the issue.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6764#issuecomment-3832044710
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6764/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
