1ec5 left a comment (openstreetmap/openstreetmap-website#3932)

Both #3938 and #6764 have attempted to chip away at this feature request by 
hard-coding a user agent indication (hashtag or otherwise) as part of the 
note’s actual body text. This gets the job done, though it’s a bit of a 
band-aid. When another mapper later encounters the note, they’ll see the 
tagline only in English. Even if we localize this string, it’s still only going 
to be in the notetaker’s language, not the reviewer’s language. If we add a 
filter by user agent, then it would need to parse the taglines out of the 
comment body.

On the other end of the spectrum, #5904 for #5294 proposes to add a flexible 
system of version-controlled note tags. This is much more complex than the 
basic task of knowing how the note was created. A note’s user agent string 
should be immutable; I don’t think a note reviewer would ever need to edit it 
for any reason.

Is there a possible middle ground of storing just the user-agent string 
alongside each note? If so, then could the website backend automatically record 
the User-Agent header of the request that posts the note and return that as an 
additional field in the /notes/#id response? If and when we later introduce a 
full-fledged tagging system for notes, we could upgrade this user agent field 
to a tag, or we could leave it separate since it’s immutable.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/3932#issuecomment-3846959872
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/issues/3932/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to