@hlfan commented on this pull request.


> +  background-color: lighten($green, 35%);
+  color: darken($green, 40%);

This is basically `bg-success-subtle text-success-emphasis`, the link 
`text-success`.
Branding a notice as `success` is definitely a curious choice.

> +    &::before {
+      content: attr(data-compact-message);

Is there a reason the compact message has to be in a pseudo-element?

> +  a.btn.btn-link {
+    color: darken($vibrant-green, 25%);
+  }
+
+  /*
+   Show compact message for small containers (only height).
+   For width there are bootstrap adjustments 
+   */
+  @container (max-height: 60px) {
+    p {
+      display: none !important;
+    }
+
+    &::before {
+      content: attr(data-compact-message);
+      text-align: center;

You can drop this line if you put `text-center` on `maplibre-error`.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6782#pullrequestreview-3776207628
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/6782/review/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to