@hlfan commented on this pull request.
> @@ -14,7 +14,7 @@
<% @comments.each do |comment| -%>
<tr>
<td width="25%" class="<%= "text-muted" unless comment.visible? %>"><%=
link_to comment.changeset.id, changeset_path(comment.changeset) %></td>
- <td width="25%" class="<%= "text-muted" unless comment.visible?
%>"><span title="<%= l comment.created_at, :format => :friendly %>"><%=
time_ago_in_words(comment.created_at, :scope =>
:"datetime.distance_in_words_ago") %></span></td>
+ <td width="25%" class="<%= "text-muted" unless comment.visible? %>"><%=
friendly_date_ago comment.created_at %></td>
I'm aware of how backwards this looks. But I'd argue that since helpers setting
the title attribute are more specialized, this setting is more to spot
inconsistencies of when what should be used.
While I see not enabling the rule as an option, lowering its severity may be a
more suitable way.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6798#discussion_r2796212786
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6798/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
