@pablobm commented on this pull request.


> @@ -2,6 +2,15 @@
 
 /* globals iD */
 
+(() => {
+  const originalReplaceState = window.history.replaceState;
+  window.history.replaceState = function (...args) {
+    const result = originalReplaceState.apply(this, args);
+    window.dispatchEvent(new CustomEvent("replaceHistoryState", { detail: args 
}));
+    return result;
+  };
+})();

This makes me very uneasy. Is this overwrite common? Did @HolgerJeromin have an 
opinion on this? I saw the comment was resolved.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6811#pullrequestreview-3876598391
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/6811/review/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to