@Robot8A commented on this pull request.
> + if (this._credit) {
+ attribHTML += this._credit.donate ? " ♥️ " : ". ";
+ attribHTML += this._buildCreditHtml(this._credit);
+ }
+
+ attribHTML += ". ";
+
+ const termsLink = document.createElement("a");
+ termsLink.href = "https://wiki.osmfoundation.org/wiki/Terms_of_Use";;
+ termsLink.target = "_blank";
+ termsLink.rel = "noopener noreferrer";
+ termsLink.textContent =
OSM.i18n.t("javascripts.map.website_and_api_terms");
+ attribHTML += termsLink.outerHTML;
Third-party users are using OSMF resources when they use the embed, so why hide
it? :wink:
I don't know how well used it is, given that it's difficult, if not impossible
to find this embed function from the Export menu on the website, although a
quick GitHub search tells me that quite a few repos use it
(https://github.com/search?q=openstreetmap.org%2Fexport%2Fembed&type=code&ref=advsearch).
On the main website itself, I can understand hiding it if the new donate button
on the top bar works well, which I'd say is still too early to measure.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6804#discussion_r2896095741
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6804/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
