@1ec5 commented on this pull request.
> @@ -40,6 +40,10 @@
:corpmembers =>
link_to(t("layouts.partners_corpmembers"),
"https://osmfoundation.org/wiki/Corporate_Members";),
:partners =>
link_to(t("layouts.partners_partners"),
"https://hardware.openstreetmap.org/thanks/";) %>
</p>
+ <p class="fs-7 fw-light">
+ <%= t "layouts.welcome_tou_notice_html",
+ :terms_link => link_to(t("layouts.terms_of_use"),
"https://osmfoundation.org/wiki/Terms_of_Use";) %>
Looks like we make the URL localizable for the link to the same terms on the
About page:
https://github.com/openstreetmap/openstreetmap-website/blob/8cc5220c25ff6e0654bfbfed7f8c63b186b09466/config/locales/en.yml#L2345
Should it remain localizable in both places? The OSMF doesn’t publish any
localized versions of the terms, so the most a translator can do is to append
`?uselang=xyz` to force the OSMF site navigation to the same language. If we
don’t make it localizable, maybe it should be a configuration option, similar
to what we did in #6617 for the donation site.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6866#pullrequestreview-3919391279
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6866/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
