Re: [openstreetmap/openstreetmap-website] Add Codeberg social link icon and URL pattern support (#6814) (PR #6855)

[Arpan Mukherjee via rails-dev]

Arpan200502 left a comment (openstreetmap/openstreetmap-website#6855)

> I just had a look. I can see the icon in dark mode, but not in light mode:
> 
> <img alt="Example of social link on light mode. No icon showing." width="296" 
> height="115" 
> src="https://private-user-images.githubusercontent.com/36066/562352082-279519a1-0bcb-41ab-bc4c-0b443a33b8ad.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzMzMzMxMjIsIm5iZiI6MTc3MzMzMjgyMiwicGF0aCI6Ii8zNjA2Ni81NjIzNTIwODItMjc5NTE5YTEtMGJjYi00MWFiLWJjNGMtMGI0NDNhMzNiOGFkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAzMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMzEyVDE2MjcwMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTcwZTc2N2NjODA0MzRiMjU1YmIyMDE4NWQ1N2IzMDlmMDkyZDliNDVkMzNmOGQ4ZjU2YWU2MjgzZGY5MDJmODgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.VypPpicu5HUqAhCnmLoKDKfL7o0WA-hkD5dN1OAAeOg";>
>  <img alt="Example of social link on dark mode. The Codeberg icon is 
> showing." width="296" height="115" 
> src="https://private-user-images.githubusercontent.com/36066/562352135-83cf3b4d-0520-4fb8-9667-3049bfe0ee01.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzMzMzMxMjIsIm5iZiI6MTc3MzMzMjgyMiwicGF0aCI6Ii8zNjA2Ni81NjIzNTIxMzUtODNjZjNiNGQtMDUyMC00ZmI4LTk2NjctMzA0OWJmZTBlZTAxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAzMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMzEyVDE2MjcwMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTg2YmVhOWE0MzdjYmM2ODEzYjFkNTA4ZDE4NTU2MDAxYzFiNDQ0OTliMTVlZWRkODI1NGY5ODM0NDkzZGFlOWImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.F_7Rk4NVXdc35NeDkd9Pv14vXoPtgNSP0_NvrGaQBFk";>
> Re: optimising the inline SVGs. Could it be that they are actually being 
> optimised? The docs for `inline_svg` say:
> 
> > This gem adds Rails helper methods (`inline_svg_tag` and 
> > `inline_svg_pack_tag`) that read an SVG document (via Sprockets or 
> > Shakapacker, so works with the Rails Asset Pipeline), applies a CSS class 
> > attribute to the root of the document and then embeds it into a view.
> 
> In turn, [image_optim_rails](https://github.com/toy/image_optim_rails) works 
> with Sprockets. Therefore the inline SVGs might be benefitting?

Fix Codeberg SVG icon visibility in light mode

Replace hardcoded white fill with currentColor so the icon
inherits the surrounding text color and renders correctly
in both light and dark themes.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6855#issuecomment-4048139379
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/6855/c4048139...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev