@hlfan commented on this pull request.
> <%= builder.text_area(attribute, options.merge(:wrapper => false,
> "data-preview-url" => preview_url(:type => type))) %>
</div>
- <div id="<%= id %>_preview" class="tab-pane">
- <div class="richtext_placeholder text-center py-5" hidden><%= render
"shared/loader" %></div>
+ <div id="<%= id %>_preview" class="tab-pane" role="tabpanel">
+ <div class="richtext_placeholder text-center py-5" hidden>
+ <div class="spinner-border" role="status">
+ <span class="visually-hidden"><%= t("browse.start_rjs.loading")
%></span>
Could you rebase your code in a way that keeps the shared loader partial?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6691#pullrequestreview-4213598177
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6691/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
