1ec5 left a comment (openstreetmap/openstreetmap-website#7061)
> Yes it comes from
> https://github.com/JOSM/tag2link/blob/543fcd2e9181a6a0b0fddb3a4a96c4b58b4bb65c/index.json#L1556-L1561
> which just says to substitute the tag value in the link.
We currently have a special case to wrap tag2link for opening hours–like keys.
I guess we could safely append some more parameters for the location.
https://github.com/openstreetmap/openstreetmap-website/blob/ef0f868da821ccc360eda5233af26845d959b45c/app/helpers/browse_tags_helper.rb#L53-L54
> The complexity here will be calculating the location to send. For a node it's
> simple, for a way less so (first node? Weighted average of node locations?
> Conversion to geometry and then some form of centroid?) and for a relation
> it's even worse (e.g. route relations vs multipolygon buildings, parent
> relations).
The opening hours links are only relevant to points of interest, since we
aren’t attempting to linkify conditional restrictions on roadways
(`*:conditional=*`). Most POIs are small enough that we could even get away
with returning the coordinate of any arbitrary node along the edge of the area
and it would still result in a reasonable opening hours interpretation.
However, parks and nature reserves can be larger and often span administrative
areas.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/7061#issuecomment-4389991253
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/issues/7061/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
