@tyrasd commented on this pull request.
>
$(this)
+ .toggleClass("active", active)
FYI: this fixes a very minor bug: if an `active` nav item is collapsed and
later expanded again, the wrong item can get the text emphasis class
(`expandSecondaryMenuItem` relies on the `.active` class, but
`updateSecondaryNav` until now only sets the `…-emphasis` class directly).
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7062#pullrequestreview-4244583351
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/7062/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
