### Description Often, newcomers don't understand the OSM note workflow and click the `Resolve` button in the hopes that their changes will appear on the map. After that, they can reopen the note, even repeat it again.
The situation is further aggravated by the fact that in languages like Russian, the translation is close in meaning to the word "Close", and beginners confuse this button, thinking it will close the tab. I propose not to provide the option to close a note **without comment** if the user has not made any edits to the map. This is not an API-level change, because in iD, for example, you typically close notes first and then submit map changes. There's one special case: sometimes people accidentally reactivate a note. In this case, it's better to simply let the user close the note. For these cases, a check has been added to ensure that the last comment was made by the current user. ### How has this been tested? Form for user without changesets: <img width="50%" src="https://github.com/user-attachments/assets/bf85d3c2-d14f-434e-bcee-be991ffc93ad" /> For user without changesets with his comment: <img width="50%" src="https://github.com/user-attachments/assets/187cd63a-c173-4c7b-9fe1-25a7d016b518" /> For user with changesets: <img width="50%" src="https://github.com/user-attachments/assets/29edb309-ecd9-4406-8438-9be45ef4907b" /> E2E-tests have also been added. ### About implementation The initial button is selected on the server. An additional field `can_resolve_without_comment` is added to the button, which is checked on the JS side, when entering text. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/7083 -- Commit Summary -- * Hide note resolving without comment button for users without map changes -- File Changes -- M app/assets/javascripts/index/note.js (3) M app/helpers/note_helper.rb (4) M app/views/notes/show.html.erb (20) M test/system/note_comments_test.rb (3) M test/system/resolve_note_test.rb (29) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/7083.patchhttps://github.com/openstreetmap/openstreetmap-website/pull/7083.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/7083 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/[email protected]>
_______________________________________________ rails-dev mailing list [email protected] https://lists.openstreetmap.org/listinfo/rails-dev
