@pablobm commented on this pull request.
> + <%= t(
+ ".notification_header_html",
+ :changeset_comment_link => link_to(
+ t(".changeset_comment"),
+ changeset_path(
+ notification.changeset,
+ :anchor => "c#{notification.comment_id}"
+ )
+ ),
+ :commenter_name_link => link_to(
+ notification.commenter.display_name,
+ notification.commenter
+ ),
+ :time_ago => friendly_date_ago(notification.timestamp)
+ ) %>
I have reached a design that I'm liking enough for now and should cover all the
bases. I have gone for different wordings from those used in email... because I
don't like the email ones :sweat: I think my choices are simpler and the emails
could be improved.
Also the ability for reuse is a bit limited. Even for translation strings,
reusing across different contexts is tricky. I'm not sure it can be done
without having to write long keys in each case (eg: `t(".subject")` vs
`t("some_context.notifications.changeset_comment.subject")`).
The templates do have a lot of repetition. I could go try DRY them up a bit,
but at this stage it's better if we put them to the test first.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7030#discussion_r3237019063
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/7030/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
