@tomhughes commented on this pull request.


>      @frame_id = "member_relation_#{@feature.id}"
 
-    return deny_access(nil) if @feature.redacted? && !params[:show_redactions]
+    return deny_access(nil) if @feature.redacted? && 
params[:show_redactions].blank?

There's a lot of inconsistency around how flag parameters like that are 
handled...

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7090#discussion_r3252640961
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/7090/review/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to