@Rub21 commented on this pull request.
> @@ -0,0 +1,6 @@
+# frozen_string_literal: true
+
+class GpsRecord < ApplicationRecord
I agree, GPS is technically only the American system, and "trace" naming is
more consistent with the existing Trace model.
I can rename all the required values and files, e.g.:
- GpsRecord → TraceRecord
- DB openstreetmap_gps → openstreetmap_traces
- db/gps_migrate/ → db/traces_migrate/
- db/gps_structure.sql → db/traces_structure.sql
We also need to rename things in chef. openstreetmap/chef#846 already uses gps
(props, the database.yml.erb section,etc ), so we should rename there too to
keep both sides in sync.
@tomhughes wdyt?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7111#discussion_r3325975875
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/7111/review/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
