pablobm left a comment (openstreetmap/openstreetmap-website#7124)
> To do it we would need to implement our own S3 code, we can implement that in
> other PR.
My concern then is that this introduces new steps in this effort. If we do as
you say, then we'll still need the `if trace.file.metadata["server_gzipped"]`
paths in both controllers, serving the files that were uploaded in the interim.
That's a maintainability issue (code to handle a situation that existed only
for a short period), so we should migrate away from that too.
So the steps would be:
1. This PR.
2. PR with custom S3 uploader that sets `Content-Encoding`.
3. Ops team to run a script that converts (re-uploads?) the `server_gzipped`
files to have `Content-Encoding` on S3.
- That's probably for you to write and @tomhughes to run.
4. PR that removes the `if trace.file.metadata["server_gzipped"]` paths.
This sounds a bit more complex. What do Ops think? Would it be worth doing
properly the first time?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7124#issuecomment-4707485282
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/7124/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
