@tomhughes commented on this pull request.
> @@ -233,9 +233,16 @@
get "/forgot-password.html", :to => redirect(:path =>
"/user/forgot-password")
# omniauth
- get "/auth/failure" => "users#auth_failure"
- match "/auth/:provider/callback" => "users#auth_success", :via => [:get,
:post], :as => :auth_success
- match "/auth/:provider" => "users#auth", :via => [:post, :patch], :as =>
:auth
+ scope "/auth", :as => :auth do
+ get "/failure" => "users#auth_failure"
+
+ scope ":provider" do
+ match "/callback" => "users#auth_success", :via => [:get, :post], :as =>
:success
+ match "" => "users#auth", :via => [:post, :patch]
+
+ resource :delete, :only => [:show, :create], :module => "accounts",
:controller => "auth_deletions"
I think you're right though singular vs plural is a bit of a dilemma as you
say... If it's plural then it should be `resources` really I think but then the
`show` action will want an ID so maybe we put the signed token there instead of
as a parameter?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7093#discussion_r3493292100
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/7093/review/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
