tomhughes left a comment (openstreetmap/openstreetmap-website#7197)
I've done a careful comparison of the before and after here, manually resolving
the small screen (for the old version) and large screen (for the new version)
styles by merging the break point changes into the base and then comparing the
resulting small screen and large screen versions.
The result appears to be identical, apart from the addition of `width: auto` in
one place, which is correct because it's undoing a width restriction from the
small screen version for the large screen version which had no width before.
The only other difference is that we now have `
.overlay-sidebar.overlay-right-sidebar` rules in the large screen version but
I've compared them to what the current site does in the inspector and they are
only stating things that are already true.
So I think this looks good to me and we should merge and address any
improvements separately as @gravitystorm suggests as it wouldn't be possible to
do such a comparison if we mix in other changes.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7197#issuecomment-4867916924
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/7197/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
