@pablobm commented on this pull request.


> +    @extend .d-flex;
+    @extend .flex-column;
+    @extend .flex-md-row;

Should we be avoiding Sass-specific syntax? Currently there are 7 uses of 
`@extend`, which these lines bring up to 10.

I'm not sure if there's an agreement on removing Sass in the long term, but 
from my question at 
https://github.com/openstreetmap/openstreetmap-website/issues/6679 I'm thinking 
it's not out of the question.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7207#pullrequestreview-4636210190
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/7207/review/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to