In some circumstances, I'd agree, but we were working on both an engine, and a couple of sites that used the engine - this was the simplest workflow we could come up with. It seems excessive to commit changes, push to github, then use bundler to pull those same changes down to a different location on your machine as part of your day to day workflow.
Once the bulk of the work was done and the engine was reasonably complete though, I think the approach you're suggesting would have been fine. My contract ended before we got to that stage though, so I don't know how it ended up! :) Cheers, W. On 13/09/2011, at 9:52 AM, Pat Allan wrote: > Environment variables in a Gemfile feel like a code smell to me - if it's a > gem you're all working on, then I'd just push all my changes to the gem into > a certain branch on Github. > > Of course, using :path while working on it is helpful - I'd just change the > Gemfile but not check it in while working on it. But yeah, that's not ideal > either. > > -- > Pat > > On 13/09/2011, at 9:20 AM, Warren Seen wrote: > >> Yes, that is true, there is an extra step involved in re-running bundle >> whenever Gemfile.lock gets updated. Not a huge deal in practice mind you, >> since you'll know pretty quickly if you've forgotten that step. :) >> >> On 13/09/2011, at 9:15 AM, Simon Russell wrote: >> >>> The only problem there is that your Gemfile.lock will be changing >>> depending on who's making it, but that can be managed. >>> >>> On Tue, Sep 13, 2011 at 08:53, Warren Seen <[email protected]> wrote: >>>> +1 for this approach, have used it in the past too. Setting an env var is a >>>> dead simple approach and doesn't force your whole team into the same >>>> working >>>> directory setup. >>>> On 13/09/2011, at 8:49 AM, Fred Wu wrote: >>>> >>>> We used something like this: >>>> >>>> https://github.com/stonean/slim/blob/master/Gemfile >>>> >>>> >>>> >>>> -- >>>> You received this message because you are subscribed to the Google Groups >>>> "Ruby or Rails Oceania" group. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msg/rails-oceania/-/JpQF1R5DJskJ. >>>> To post to this group, send email to [email protected]. >>>> To unsubscribe from this group, send email to >>>> [email protected]. >>>> For more options, visit this group at >>>> http://groups.google.com/group/rails-oceania?hl=en. >>>> >>>> -- >>>> You received this message because you are subscribed to the Google Groups >>>> "Ruby or Rails Oceania" group. >>>> To post to this group, send email to [email protected]. >>>> To unsubscribe from this group, send email to >>>> [email protected]. >>>> For more options, visit this group at >>>> http://groups.google.com/group/rails-oceania?hl=en. >>>> >>> >>> -- >>> You received this message because you are subscribed to the Google Groups >>> "Ruby or Rails Oceania" group. >>> To post to this group, send email to [email protected]. >>> To unsubscribe from this group, send email to >>> [email protected]. >>> For more options, visit this group at >>> http://groups.google.com/group/rails-oceania?hl=en. >>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Ruby or Rails Oceania" group. >> To post to this group, send email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]. >> For more options, visit this group at >> http://groups.google.com/group/rails-oceania?hl=en. >> > > -- > You received this message because you are subscribed to the Google Groups > "Ruby or Rails Oceania" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/rails-oceania?hl=en. > -- You received this message because you are subscribed to the Google Groups "Ruby or Rails Oceania" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/rails-oceania?hl=en.
