I bought and started reading this while in Byron Bay over the weekend with my band (yay Kindle 3G!)
Highly recommended and will be very useful while I try to tidy up this project. On Wed, Oct 12, 2011 at 12:43 PM, Dmytrii Nagirniak <[email protected]>wrote: > I believe you can follow the checklist from Rails Antipatterns book. > http://www.informit.com/store/product.aspx?isbn=0321620283 > > And another TODO entry I would add: "Is application Rails 3" :) > > Cheers. > > On 12/10/2011, at 10:06 AM, Michael Pearson wrote: > > Hi, > > We have a large Rails 2.3.x codebase, mostly written by a developer without > prior experience with Rails who has since left the company. > > What I'm trying to do is put together a list of things to look out for and > continually improve, specific to Rails 2.x. > > Most of the below seems to be about removing code duplication and fixing > Law of Demeter violations: > > - use flay to identify code duplication > - remove all instances of raw SQL outside of app/models by using model > methods and named scopes > - ensure controllers aren't calling other controllers directly > - create crudify-like base class for controllers generated using > script/generate scaffold > - parse logs to identify unused controllers > > Notably not on this list is unit or integration testing. The code is not at > the point where this can be performed effectively. > > Any Rails-istas have any tips for other things to look out for? This list > is intended as things to fix while we're working on bugfixes or new features > rather than trying to perform a ground-up rewrite. > > Also, are there any tools that can replay a log and perform code coverage > analysis in Ruby? Has anybody adapted rspec's coverage tools to do this? > > -- > Michael Pearson > The Bon Scotts; http://www.thebonscotts.com > > > -- > You received this message because you are subscribed to the Google Groups > "Ruby or Rails Oceania" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/rails-oceania?hl=en. > > > -- > You received this message because you are subscribed to the Google Groups > "Ruby or Rails Oceania" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/rails-oceania?hl=en. > -- Michael Pearson The Bon Scotts; http://www.thebonscotts.com -- You received this message because you are subscribed to the Google Groups "Ruby or Rails Oceania" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/rails-oceania?hl=en.
