Sammi, I didn't look at the code, but I would say, keep sending your stuff, good stuff. As far as any official patch, who knows. The people that need/want the functionality you are offering will take it and run with it. Those that don't want a modified core file will figure out how to take your stuff and factor it into a separate file. Just keep contributing like this.
As far as indenting... the fact that the author(s) used spaces for indentation in the first place has always been an annoyance. Why not just hit the TAB key once and make all tabs equal rather than hitting space multiple times and ending up with all sorts of inconsistent indentation? -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Todd Ross Sent: Friday, February 17, 2006 5:53 AM To: rails-spinoffs@lists.rubyonrails.org Subject: Re: [Rails-spinoffs] Sortable Tree Addition [PATCH] On 2/17/06, Maninder, Singh <[EMAIL PROTECTED]> wrote: > Remove the "+" and change it to " " (space) > http://www.oriontransfer.co.nz/Sortable List v2.zip That did the trick. Thanks. So, onto the feedback for Sammi: 48,62d47 > /* Copyright Sammi Williams 2006 Released under GPLv2 */ > Object.keys = function(object) { > var keys = new Array(); > for (key in object) > keys.push (key); > return keys; > } > > Object.values = function(object) { > var values = new Array(); > for (key in object) > values.push (object[key]) > return values; > } Prototype is a BSD-licensed package; why would they accept code licensed under a different license? Neither of those functions are written in the style of the rest of the Prototype code. The way they're declared and the indenting you're using isn't consistant with Prototype. They're also unnecessary ... var keys = $H(object).keys(); ... will give you what you want. Same with values(). 413,414c428,429 < for (var i = 0; i < this.length; i++) < iterator(this[i]); --- > for (var i = 0; i < this.length; i++) > iterator(this[i]); 1785c1800 < } --- > } You just changed the indenting for the fun of it? Todd _______________________________________________ Rails-spinoffs mailing list Rails-spinoffs@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-spinoffs The information transmitted in this electronic mail is intended only for the person or entity to which it is addressed and may contain confidential, proprietary, and/or privileged material. Any review, retransmission, dissemination or other use of, or taking of any action in reliance upon, this information by persons or entities other than the intended recipient is prohibited. If you received this in error, please contact the sender and delete the material from all computers. _______________________________________________ Rails-spinoffs mailing list Rails-spinoffs@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-spinoffs
