Yeah it was a typical "get it working and clean it up as you go along" job. If I re-visit that code any time soon I'll take your suggestions onboard and submit another patch.
-Rob Martin Bialasinski wrote: > On 3/1/06, Robin Haswell <[EMAIL PROTECTED]> wrote: > >>Patch to allow generic Ajax.Autocompleter-style textbox watchers. > > > Looks good. But check this: > > this.hasFocus is never used. > In onObserverEvent, check if the value has really changed since the > last remote call (user might have just moved the caret or he might > have reverted his changes). No need to hit the server in that case. > _______________________________________________ > Rails-spinoffs mailing list > Rails-spinoffs@lists.rubyonrails.org > http://lists.rubyonrails.org/mailman/listinfo/rails-spinoffs _______________________________________________ Rails-spinoffs mailing list Rails-spinoffs@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-spinoffs
