Re: [Rails-spinoffs] issue with last update to scriptaculous

Thu, 17 Aug 2006 08:21:12 -0700

Um, can anyone confirm my last post, is the problem that I found a bug?

On 8/16/06, Brian Peiris <[EMAIL PROTECTED] > wrote:
I think I found another issue:
dragdrop.js ~line 255:
    if(options.handle && (typeof options.handle == 'string')) {
      var h = Element.childrenWithClassName(this.element, options.handle, true);
      if(h.length>0) this.handle = h[0];
    }
Since the 'findFirst' attribute of childrenWithClassName is set to true, a single element is returned, and not an array, thus h[0] would not work, correct?

At least it doesn't seem to work in Firefox 1.5.0.6:
http://dev.rubyonrails.org/svn/rails/spinoffs/scriptaculous/test/unit/effects_test.html
once the tests are done try:
_javascript_:var h = Element.childrenWithClassName('loglines','passed',true); alert('This fails: '+h[0]); alert('This works: '+h);


On 8/16/06, Javier Martinez <[EMAIL PROTECTED]> wrote:
jejeje good fix :)
Now it seems that works well!


2006/8/16, Thomas Fuchs < [EMAIL PROTECTED]>:
So, a new version is now available from SVN (revision 4772), can you give this a try?

Best,
Thomas

Am 16.08.2006 um 12:12 schrieb Javier Martinez:

I can't provide you a URL because the project I'm working is on development. But the draggables that fails are the draggables that have a "endeffect" overriding the default one on the dragdrop.js file. The browser I'm using is firefox and the os is xp pro.
I think that the behavior is normal, because I'm overriding the function "Draggable._dragging[element] = false" but maybe this is not the place where to put this line of code ( If I write this line on my endeffect function, all is OK again ).



2006/8/16, Thomas Fuchs <[EMAIL PROTECTED]>:
I still can't reproduce this. :(

If possible please provide a URL for it, plus state Browser/OS.
I really want to fix this... :)

-Thomas

Am 16.08.2006 um 11:58 schrieb Javier Martinez:

Yes, I override the default "endeffect" and the line "Draggable._dragging[element] = false" is not executed.



2006/8/16, Thomas Fuchs < [EMAIL PROTECTED]>:
Btw, can you provide a online URL with this? I've now tested in all browsers, and while there is a problem in the 1.6.2 code, the functional tests seems to work well despite the problem.

Do you use any special options (reverteffect/starteffect/endeffect)?

-Thomas


Am 16.08.2006 um 11:42 schrieb Javier Martinez:

I'm testint last scriptaculous update on a project, and I observed some issue with draggables. Now, I only can drag a layer one time. When the draggable deactivates, not activates again.
I have seen that the error comes on this line ( on initDrag function )

-------------------------------------------------------------------------------------------------
    if(typeof Draggable._dragging[this.element ] != undefined &&
      Draggable._dragging[this.element ]) return;

-------------------------------------------------------------------------------------------------

First time, "typeof Draggable._dragging[ this.element]" is undefined ( then the draggable activates ), but when I release the mouse and try to move the layer again, it has "boolean" value and the draggable don't activates.

Somebody knows why?

Thanks.
_______________________________________________
Rails-spinoffs mailing list

--
Thomas Fuchs
wollzelle


questentier on AIM
madrobby on irc.freenode.net
 
http://www.fluxiom.com :: online digital asset management
http://script.aculo.us ::  Web 2.0 _javascript_
http://mir.aculo.us :: Where no web developer has gone before


_______________________________________________
Rails-spinoffs mailing list
Rails-spinoffs@lists.rubyonrails.org
http://lists.rubyonrails.org/mailman/listinfo/rails-spinoffs



_______________________________________________
Rails-spinoffs mailing list

--
Thomas Fuchs
wollzelle


questentier on AIM
madrobby on irc.freenode.net
 
http://www.fluxiom.com :: online digital asset management
http://script.aculo.us ::  Web 2.0 _javascript_
http://mir.aculo.us :: Where no web developer has gone before


_______________________________________________
Rails-spinoffs mailing list
Rails-spinoffs@lists.rubyonrails.org
http://lists.rubyonrails.org/mailman/listinfo/rails-spinoffs



_______________________________________________
Rails-spinoffs mailing list

--
Thomas Fuchs
wollzelle


questentier on AIM
madrobby on irc.freenode.net
 
http://www.fluxiom.com :: online digital asset management
http://script.aculo.us :: Web 2.0 _javascript_
http://mir.aculo.us :: Where no web developer has gone before


_______________________________________________
Rails-spinoffs mailing list
Rails-spinoffs@lists.rubyonrails.org
http://lists.rubyonrails.org/mailman/listinfo/rails-spinoffs




_______________________________________________
Rails-spinoffs mailing list
Rails-spinoffs@lists.rubyonrails.org
http://lists.rubyonrails.org/mailman/listinfo/rails-spinoffs





--
============================
Brian Peiris
Brampton, Ontario, Canada
[EMAIL PROTECTED] or [EMAIL PROTECTED]
============================



--
============================
Brian Peiris
Brampton, Ontario, Canada
[EMAIL PROTECTED] or [EMAIL PROTECTED]
============================ 
_______________________________________________
Rails-spinoffs mailing list
Rails-spinoffs@lists.rubyonrails.org
http://lists.rubyonrails.org/mailman/listinfo/rails-spinoffs

Reply via email to