[
https://issues.apache.org/jira/browse/RAMPART-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ruchith Udayanga Fernando reassigned RAMPART-48:
------------------------------------------------
Assignee: Ruchith Udayanga Fernando
> RampartMessageData class needs tightening
> -----------------------------------------
>
> Key: RAMPART-48
> URL: https://issues.apache.org/jira/browse/RAMPART-48
> Project: Rampart
> Issue Type: Improvement
> Reporter: Glen Mazza
> Assignee: Ruchith Udayanga Fernando
> Attachments: rampartMessageData.patch
>
>
> I fixed some typos and apparent minor bugs in this class. I also deprecated
> four setters() that were not being used anywhere in Axis2 nor Rampart, but
> more importantly, if actually called externally, would appear to circumvent
> to process flow of the class (i.e., the state of the object would become
> inconsistent if they were called). I got the impression that some of these
> setters were quickly added in at class construction, but their actual use
> cases were not fully explored. I don't expect this patch to be applied in its
> entirety (I may very well be wrong in quite a few areas), but for everything
> obviously wrong to be immediately applied, and the rest left for more
> discussion/clarification if necessary.
> There are also NPE's[1] coming from this class from three or four static
> methods where the passed-in msgContext has a NULL service--I did not do much
> to cover this area, as I'm unsure what would be optimal (returning NULL or an
> IllegalStateException or an RampartFault...) Leaving this matter to the
> Axis2/Rampart team.
> [1] http://marc.info/?l=axis-user&m=118191892826128&w=2
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
