HI Amine,

unfortunately you need to open a second CQ for your own code contribution.
The piggyback CQ is only for using ACE.

Regards,
Markus


On 9 November 2016 at 13:22, Amine Lajmi <[email protected]> wrote:

> Hi Markus,
>
> Ivan has already opened a piggyback CQ: https://dev.eclipse.org/ipzill
> a/show_bug.cgi?id=12234
> I guess I can attach the initial code to this one right ?
>
> Regards,
> Amine
>
> 2016-11-09 11:39 GMT+01:00 Markus Knauer <[email protected]>:
>
>> Now that the ACE part has been solved, I think it is time to move the
>> current code contribution with a CQ through the IP review process.
>>
>> @Amine, can you create a CQ with your initial code contribution and add
>> me as CC to the CQ? The project handbook at [1] describes the required
>> steps. If there is anything unclear we can try to solve this.
>>
>> [1] https://www.eclipse.org/projects/handbook/#ip-initial-contribution
>>
>>
>> Thanks,
>> Markus
>>
>>
>>
>>
>>
>> On 9 November 2016 at 11:05, Ivan Furnadjiev <[email protected]>
>> wrote:
>>
>>> Hi Amine,
>>> the mentioned CQ by Nedelcho (https://dev.eclipse.org/ipzil
>>> la/show_bug.cgi?id=11808) is already approved. In order to use the ACE
>>> editor in RAP Incubator styled text widget I've opened a piggyback CQ:
>>> https://dev.eclipse.org/ipzilla/show_bug.cgi?id=12234
>>> Once it is approved too (should not take too long) we can proceed
>>> further.
>>> Regards,
>>> Ivan
>>>
>>>
>>> On 10/31/2016 22:53, Amine Lajmi wrote:
>>>
>>> Hi Ivan,
>>>
>>> I've cleaned up the depenencies to ACE, the scripts are now consumed
>>> from https://cdnjs.cloudflare.com/ajax/libs/ace/1.2.4/
>>>
>>> Regards,
>>> Amine
>>>
>>>
>>> 2016-10-19 14:24 GMT+02:00 Ivan Furnadjiev <[email protected]>:
>>>
>>>> Hi Amine,
>>>> today I had a brief look at the code. I saw that the JS code of the ACE
>>>> editor is included in one of the bundles. In this case, before we push it
>>>> to the RAP incubator it has to go through the Eclipse IP process. Is it
>>>> possible to consume the ACE editor from a remote location (
>>>> https://cdnjs.com/libraries/ace for example)? We did this with NVChart
>>>> library ( example is here http://git.eclipse.org/c/rap/i
>>>> ncubator/org.eclipse.rap.incubator.chart.git/tree/bundles/or
>>>> g.eclipse.rap.addons.chart/src/org/eclipse/rap/addons/chart/
>>>> NvChart.java). The external location can be overrided with a system
>>>> property. Can we do it in the same way?
>>>> Regards,
>>>> Ivan
>>>>
>>>> On Fri, Sep 23, 2016 at 12:09 PM, Amine Lajmi <[email protected]>
>>>> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> The styled text editor component is ready for incubation. I've renamed
>>>>> the plugins accordingly and setup a temporary repository on GitHub [1].
>>>>> Regarding the creation of the repository on [2], should I open a regular
>>>>> bug under Community/Git or request the repo creation via this mailling 
>>>>> list
>>>>> ?
>>>>>
>>>>> Thanks in advance for clarifying!
>>>>>
>>>>> Regards,
>>>>> Amine
>>>>>
>>>>> [1] https://github.com/plugbee/org.eclipse.rap.addons.texteditor
>>>>> [2] https://git.eclipse.org/c/rap/incubator/
>>>>>
>>>>>
>>>>> 2016-02-04 9:43 GMT+01:00 Ralf Sternberg <[email protected]
>>>>> >:
>>>>>
>>>>>> Hi Amine,
>>>>>>
>>>>>> thanks for the clarification. We're happy to create a new incubator
>>>>>> component for these widgets. Markus will help you with the technical
>>>>>> details of becoming a committer, getting IP clearance, and setting up the
>>>>>> repository.
>>>>>>
>>>>>> Thanks for sharing your work with the RAP community!
>>>>>>
>>>>>> Regards,
>>>>>> Ralf
>>>>>>
>>>>>> --
>>>>>> Ralf Sternberg
>>>>>> Project Lead, Remote Application Platform (RAP)
>>>>>> EclipseSource
>>>>>>
>>>>>> Tel: +49 721 66 47 33-0
>>>>>>
>>>>>> Innoopract Informationssysteme GmbH
>>>>>> Lammstraße 21, 76133 Karlsruhe, Germany
>>>>>> General Manager: Jochen Krause
>>>>>> Registered Office: Karlsruhe, Commercial Register Mannheim HRB 107883
>>>>>>
>>>>>> On Mon, Feb 1, 2016 at 12:27 AM, Amine Lajmi <[email protected]>
>>>>>> wrote:
>>>>>>
>>>>>>> Hi Ralf,
>>>>>>>
>>>>>>> Here is a very quick reply to your questions.
>>>>>>>
>>>>>>> - If I understand correctly, you're proposing to include only the
>>>>>>> editor itself in the component. Could you provide a list of bundles to
>>>>>>> include from the github repository?
>>>>>>> - org.dslforge.styledtext
>>>>>>> - org.dslforge.texteditor
>>>>>>> - org.dslforge.texteditor.demo
>>>>>>>
>>>>>>> - Is the widget useful without xtext / DSLs? Are there any examples
>>>>>>> for those basic use cases?
>>>>>>> Yes, there is already a BasicTextEditor class with some examples of
>>>>>>> how to use the widget [1]. DSLs with Xtext can be built on top of it, 
>>>>>>> but
>>>>>>> It can be also more general. The DSL examples, also open-source, will be
>>>>>>> maintained separately on GitHub repo. Would it be fine for you ? Let me
>>>>>>> know if you have any preferences.
>>>>>>>
>>>>>>> - Do you also have an SWT-compatible version of this editor to be
>>>>>>> used in the RCP version, or would you use StyledText there?
>>>>>>> Currently no, the editor is only used against the RAP target, I did
>>>>>>> not cross check with RCP.
>>>>>>>
>>>>>>> - What would your component be called? Since your widget is not
>>>>>>> compatible with SWT's StyledText widget, "styledtext" is likely not a
>>>>>>> suitable name, is it?
>>>>>>> Right, it's called BasicText right now, it can stay like this for
>>>>>>> the moment, I don't mind.
>>>>>>>
>>>>>>> - Following the conventions of the incubator projects, bundles and
>>>>>>> packages should probably be renamed to "org.eclipse.rap.addons.*". Would
>>>>>>> this be ok with you?
>>>>>>> No problem with that. Following the naming convention, those
>>>>>>> plugins would be called:
>>>>>>> - org.eclipse.rap.incubator.basictext
>>>>>>> - org.eclipse.rap.incubator.texteditor
>>>>>>> - org.eclipse.rap.incubator.texteditor.demo
>>>>>>>
>>>>>>> Let me know if this holds for you.
>>>>>>>
>>>>>>> - Would you agree to maintain the component, i.e. follow up on bug
>>>>>>> reports, adjust the build for new RAP version etc?
>>>>>>> Sure.
>>>>>>>
>>>>>>> - Are you an Eclipse committer already?
>>>>>>> This is part of what should be done in the next few weeks.
>>>>>>>
>>>>>>> Best regards,
>>>>>>> Ralf
>>>>>>>
>>>>>>>
>>>>>>> I keep available for any further information.
>>>>>>> Regards,
>>>>>>> Amine
>>>>>>>
>>>>>>> [1] https://github.com/plugbee/dslforge/blob/master/plugins/
>>>>>>> org.dslforge.texteditor/src/org/dslforge/texteditor/BasicTex
>>>>>>> tEditor.java
>>>>>>>
>>>>>>>
>>>>>>> -------------------------------------------------
>>>>>>> Amine Lajmi, PhD
>>>>>>> MDE Expert
>>>>>>>
>>>>>>> Mobile: +33623756198 (preferred)
>>>>>>> Phone: +33145019650
>>>>>>> Email : [email protected]
>>>>>>> www.plugbee.com
>>>>>>>
>>>>>>> PlugBee SARL
>>>>>>> 145, rue de Lourmel
>>>>>>> 75015 Paris
>>>>>>> France
>>>>>>> -------------------------------------------------
>>>>>>>
>>>>>>>
>>>>>>> 2016-01-29 14:11 GMT+01:00 Ralf Sternberg <
>>>>>>> [email protected]>:
>>>>>>>
>>>>>>>> Hi Amine,
>>>>>>>>
>>>>>>>> thanks for your offer and sorry for the delayed response. Some
>>>>>>>> questions regarding the incubator component you'd like to create:
>>>>>>>>
>>>>>>>> - If I understand correctly, you're proposing to include only the
>>>>>>>> editor itself in the component. Could you provide a list of bundles to
>>>>>>>> include from the github repository?
>>>>>>>>
>>>>>>>> - Is the widget useful without xtext / DSLs? Are there any examples
>>>>>>>> for those basic use cases?
>>>>>>>>
>>>>>>>> - Do you also have an SWT-compatible version of this editor to be
>>>>>>>> used in the RCP version, or would you use StyledText there?
>>>>>>>>
>>>>>>>> - What would your component be called? Since your widget is not
>>>>>>>> compatible with SWT's StyledText widget, "styledtext" is likely not a
>>>>>>>> suitable name, is it?
>>>>>>>>
>>>>>>>> - Following the conventions of the incubator projects, bundles and
>>>>>>>> packages should probably be renamed to "org.eclipse.rap.addons.*". 
>>>>>>>> Would
>>>>>>>> this be ok with you?
>>>>>>>>
>>>>>>>> - Would you agree to maintain the component, i.e. follow up on bug
>>>>>>>> reports, adjust the build for new RAP version etc?
>>>>>>>>
>>>>>>>> - Are you an Eclipse committer already?
>>>>>>>>
>>>>>>>> Best regards,
>>>>>>>> Ralf
>>>>>>>>
>>>>>>>> --
>>>>>>>> Ralf Sternberg
>>>>>>>> Project Lead, Remote Application Platform (RAP)
>>>>>>>> EclipseSource
>>>>>>>>
>>>>>>>> Tel: +49 721 66 47 33-0
>>>>>>>>
>>>>>>>> Innoopract Informationssysteme GmbH
>>>>>>>> Lammstraße 21, 76133 Karlsruhe, Germany
>>>>>>>> General Manager: Jochen Krause
>>>>>>>> Registered Office: Karlsruhe, Commercial Register Mannheim HRB
>>>>>>>> 107883
>>>>>>>>
>>>>>>>> On Wed, Jan 20, 2016 at 2:38 PM, Amine Lajmi <[email protected]>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> It seems something went wrong with the urls, here are the links
>>>>>>>>> pointing to the right location.
>>>>>>>>>
>>>>>>>>> [1] https://github.com/plugbee/dslforge.git
>>>>>>>>>
>>>>>>>>> [2] http://dslforge.org
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Sorry for the spam.
>>>>>>>>>
>>>>>>>>> Regards,
>>>>>>>>>
>>>>>>>>> Amine
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> ---------- Forwarded message ----------
>>>>>>>>> From: Amine Lajmi <[email protected]>
>>>>>>>>> Date: 2016-01-20 14:23 GMT+01:00
>>>>>>>>> Subject: Proposal of a styled text widget for RAP Incubator Project
>>>>>>>>> To: [email protected]
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Greetings from Paris,
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> I’m Amine, an independent consultant working on modeling
>>>>>>>>> applications and their web applications. I would like to share my
>>>>>>>>> experience on text editing over RAP.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> I have developed DSL Forge, a tool for building textual web
>>>>>>>>> editors, and I would like to propose the main component of the tool (a
>>>>>>>>> styled text widget) as a RAP Incubator Project.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> The repository [1] contains a custom widget based on an
>>>>>>>>> integration of Cloud9 ACE and RAP. I’ve already built some textual 
>>>>>>>>> language
>>>>>>>>> editors based on the widget, please have a look on the live demo app 
>>>>>>>>> [2]
>>>>>>>>> for some examples.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> The widget is not perfect, maybe the integration with RAP is not
>>>>>>>>> optimal, but it does really make textual editors with all the styling
>>>>>>>>> features, annotations, content assist, text hover, and so on.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> I’m looking forward to get your feedback on this, I'm available
>>>>>>>>> for any further information.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> [1] https://github.com/plugbee/dslforge.git
>>>>>>>>> <http://git.dslforge.org/styledtext.git>
>>>>>>>>>
>>>>>>>>> [2] http://dslforge.org <http://dslforge.org/workbench>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Best regards,
>>>>>>>>>
>>>>>>>>> Amine Lajmi
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> -------------------------------------------------
>>>>>>>>>
>>>>>>>>> Amine Lajmi, PhD
>>>>>>>>>
>>>>>>>>> Managing Director & MDE Expert
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Mobile: +33623756198 (preferred)
>>>>>>>>>
>>>>>>>>> Phone: +33145019650
>>>>>>>>>
>>>>>>>>> Email : [email protected]
>>>>>>>>>
>>>>>>>>> www.plugbee.com
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> PlugBee SARL
>>>>>>>>>
>>>>>>>>> 145, rue de Lourmel
>>>>>>>>>
>>>>>>>>> 75015 Paris
>>>>>>>>>
>>>>>>>>> France
>>>>>>>>>
>>>>>>>>> -------------------------------------------------
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> _______________________________________________
>>>>>>>>> rap-dev mailing list
>>>>>>>>> [email protected]
>>>>>>>>> To change your delivery options, retrieve your password, or
>>>>>>>>> unsubscribe from this list, visit
>>>>>>>>> https://dev.eclipse.org/mailman/listinfo/rap-dev
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> _______________________________________________
>>>>>>>> rap-dev mailing list
>>>>>>>> [email protected]
>>>>>>>> To change your delivery options, retrieve your password, or
>>>>>>>> unsubscribe from this list, visit
>>>>>>>> https://dev.eclipse.org/mailman/listinfo/rap-dev
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> rap-dev mailing list
>>>>>>> [email protected]
>>>>>>> To change your delivery options, retrieve your password, or
>>>>>>> unsubscribe from this list, visit
>>>>>>> https://dev.eclipse.org/mailman/listinfo/rap-dev
>>>>>>>
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> rap-dev mailing list
>>>>>> [email protected]
>>>>>> To change your delivery options, retrieve your password, or
>>>>>> unsubscribe from this list, visit
>>>>>> https://dev.eclipse.org/mailman/listinfo/rap-dev
>>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> rap-dev mailing list
>>>>> [email protected]
>>>>> To change your delivery options, retrieve your password, or
>>>>> unsubscribe from this list, visit
>>>>> https://dev.eclipse.org/mailman/listinfo/rap-dev
>>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> rap-dev mailing list
>>>> [email protected]
>>>> To change your delivery options, retrieve your password, or unsubscribe
>>>> from this list, visit
>>>> https://dev.eclipse.org/mailman/listinfo/rap-dev
>>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> rap-dev mailing [email protected]
>>> To change your delivery options, retrieve your password, or unsubscribe 
>>> from this list, visithttps://dev.eclipse.org/mailman/listinfo/rap-dev
>>>
>>>
>>>
>>> _______________________________________________
>>> rap-dev mailing list
>>> [email protected]
>>> To change your delivery options, retrieve your password, or unsubscribe
>>> from this list, visit
>>> https://dev.eclipse.org/mailman/listinfo/rap-dev
>>>
>>
>>
>>
_______________________________________________
rap-dev mailing list
[email protected]
To change your delivery options, retrieve your password, or unsubscribe from 
this list, visit
https://dev.eclipse.org/mailman/listinfo/rap-dev

Reply via email to