Marija, It seems my idea of redirecting commit notifications to the list was not quite good. Could you please revert googlecode notifications to a smaller alias?
To address this issue properly I suggest attaching the source 0.1.0 release to [1] so RAT committers can consider committing the project to the RAT code base. I believe I cannot do that myself both technically and without proper approval because I'm committer of a different Apache project. BTW, thanks for creating a nice tool! I'm currently trying to apply it to a real project. Hope you will remain with Apache even after GSoC completes. [1] http://issues.apache.org/jira/browse/RAT-45 On Wed, Aug 19, 2009 at 8:27 PM, Craig L Russell<[email protected]> wrote: > I'm afraid I can't moderate these messages through any more. Please remove > rat-dev from the subscribers for these code reviews. > I like the convenience and the community building but some other technique > needs to be used. For example, the person receiving the code review can > forward it to rat-dev. But I don't have the time. > Sorry, > Craig > > Begin forwarded message: > > From: Joe Schaefer <[email protected]> > Date: August 19, 2009 8:53:17 AM PDT > To: Craig L Russell <[email protected]>, [email protected] > Subject: Re: Fwd: MODERATE for [email protected] > Google apps aren't compatible with ezmlm, sorry. That email address > should be told to disable whatever they're doing until they set up > and use a remailing address which masks the sender munging Google does. > > From: Craig L Russell <[email protected]> > To: [email protected] > Sent: Wednesday, August 19, 2009 11:45:07 AM > Subject: Fwd: MODERATE for [email protected] > > This is the fifteenth moderation request from the same email address. Are > they on the permanent "require moderation" list? > Craig > > Begin forwarded message: > > From: rat-dev-reject-1250664693.1349.kjfkfkaaeiggnegpc...@incubator.apache.org > Date: August 18, 2009 11:51:33 PM PDT > To: Recipient list not shown: ; > Cc: rat-dev-allow-tc.1250664693.agflkbhpleccelchmjin-32kclshakae8t5uv9zav-458v62fx55x2v.t53=codesite.bounces.google....@incubator.apache.org > Subject: MODERATE for [email protected] > Reply-To: rat-dev-accept-1250664693.1349.kjfkfkaaeiggnegpc...@incubator.apache.org > > To approve: > rat-dev-accept-1250664693.1349.kjfkfkaaeiggnegpc...@incubator.apache.org > To reject: > rat-dev-reject-1250664693.1349.kjfkfkaaeiggnegpc...@incubator.apache.org > To give a reason to reject: > %%% Start comment > %%% End comment > > > From: [email protected] > Date: August 18, 2009 11:51:04 PM PDT > To: [email protected] > Subject: Comment on revision r45 in apache-rat-pd > > > egor.pasko commented on revision r45 in project apache-rat-pd. > Details are at http://code.google.com/p/apache-rat-pd/source/detail?r=45 > > Score: Positive > > > Line-by-line comments: > > File: /trunk/src/main/java/org/apache/rat/pd/core/PlagiarismDetector.java > (r45) > =============================================================================== > > Line 102: pdCommandLine, out); > ------------------------------------------------------------------------------- > >>this probably looks better if wrapped after '= 'like this: > >>final List<IHeuristicChecker> algorithmsForChecking = > >> configureHeuristicCheckers(pdCommandLine, out); > > I totally agree. :) > > thanks for fixing this in some next commit > > I use default Eclipse built-in formatter. If it is better to use any > different formatter, lets do it! > > This was surprising to me. I never really used default formatting in > Eclipse, so I did not know. Here is how to fix: > Window -> Preferences -> Java -> Code Style -> Formatter -> Select a Profile > (Eclipse [built-in]) Show ... -> Indentation -> Tab policy -> Spaces only -> > Apply > > name it something like "Eclipse [spaces]" > > Then use Source -> Format to reformat individual files. Worked for me :) > > Do you like that? > > To reformat everything a quick replacement script can be run. A usual > request in such cases is not to intermix formatting changes with other work > in a single commit. > > Line 130: * @param pdCommandLine > ------------------------------------------------------------------------------- > > It is nice that you notice that. It is already done. > > thanks for doing this! it makes the code cleaner > > Line 135: List<ISearchEngine> toret = new ArrayList<ISearchEngine>(); > ------------------------------------------------------------------------------- > >>Comment by egor.pasko, Aug 05 (5 days ago): > >>hm, 'ret' is more natural to me than 'toret', 'toRet' is comprehensible too >> .. java people > just love >CamelCase > > This is correct. I like CamelCase, too! :) > > hey :) you could give a link on the revision where you fix this. I checked > the last revision. Sounds to be fixed. Thanks for that! > > Line 154: PdCommandLine pdCommandLine, PrintStream out) throws IOException > { > ------------------------------------------------------------------------------- > > Actually, if we want to use logging this way, PrintStream can be passed by > > [1]setter method > > [2]through class constructor > > [3]like public static class member > > I prefer first two approach . I think that situation in this class will be > much better if all > > methods are not static anymore. PrintStream will be then just a class > member. main > > function will be begin with: > > PlagiarismDetector pd = new PlagiarismDetector(); > > ................. > > final PrintStream out = pd.getProperPrintStream(pdCommandLine); > > I am OK with this approach. > > However, to make code shorter you could make a public setter with a > protected getter in a superclass of all heuristics. And then you do not need > to define this thing in every heuristic. And cleaning up is easier. > > Just a thought. > > Line 336: new ByteArrayOutputStream()); > ------------------------------------------------------------------------------- > > This is nice hack. :) Thanks. > > I am happy to help you, and this is not a hack :) > > Respond to these comments > at http://code.google.com/p/apache-rat-pd/source/detail?r=45 > -- > You received this message because you starred this review, or because > your project has directed all notifications to a mailing list that you > subscribe to. > You may adjust your review notification preferences at: > http://code.google.com/hosting/settings > > > > > Craig L Russell > Architect, Sun Java Enterprise System http://db.apache.org/jdo > 408 276-5638 mailto:[email protected] > P.S. A good JDO? O, Gasp! > > > > Craig L Russell > > Architect, Sun Java Enterprise System http://db.apache.org/jdo > > 408 276-5638 mailto:[email protected] > > P.S. A good JDO? O, Gasp! > -- With best regards / с наилучшими пожеланиями, Alexei Fedotov / Алексей Федотов, http://www.telecom-express.ru/ http://harmony.apache.org/ http://code.google.com/p/openmeetings/
