> -----Original Message----- > From: Gavin [mailto:[email protected]] > Sent: Thursday, 10 December 2009 8:35 PM > To: [email protected] > Subject: RE: [PATCH] Allow RAT to run on .tar.gz archives > > > > > -----Original Message----- > > From: Hyrum K. Wright [mailto:[email protected]] > > Sent: Thursday, 10 December 2009 8:52 AM > > To: [email protected] > > Subject: Re: [PATCH] Allow RAT to run on .tar.gz archives > > > > Any further progress on this patch? > > Well, we've just had some new committers voted into the Rat project, > including myself so I'll make use of those shiny new bits by taking a look > tomorrow. > > Gav...
Hyrum, thanks. Patch Applied, please see comment in RAT-17. Gav... > > > > > -Hyrum > > > > On Nov 23, 2009, at 3:35 PM, Hyrum K. Wright wrote: > > > > > Another gentle reminder that this patch is outstanding and hasn't > > received any comments/concerns/vetoes. I'd like to see this included in > > RAT as soon as is reasonable. > > > > > > Thanks, > > > -Hyrum > > > > > > On Nov 19, 2009, at 2:32 PM, Hyrum K. Wright wrote: > > > > > >> Ping. It's been a couple of days since the most recent version of > this > > patch. Any comments? > > >> > > >> -Hyrum > > >> > > >> On Nov 17, 2009, at 10:44 AM, Hyrum K. Wright wrote: > > >> > > >>> > > >>> On Nov 16, 2009, at 11:12 PM, Stefan Bodewig wrote: > > >>> > > >>>> On 2009-11-14, Hyrum K. Wright <[email protected]> > wrote: > > >>>> > > >>>>> In using RAT to check potential Subversion release tarballs, I've > > >>>>> bumped into a couple of its, uh, limitations. To that end, I've > > >>>>> hacked up the attached patch which fixes the immediate itch of not > > >>>>> wanting to have to unpack the tarball before running the tool. > > >>>> > > >>>> The RAT Antlib already supports working on arbitrary resource > > >>>> collections, which means you wouldn't even have to download the > > tarball > > >>>> yourself if you wanted to. > > >>>> > > >>>> <rat:report ...> > > >>>> <tarfileset ...> > > >>>> <url .../> > > >>>> </tarfileset> > > >>>> </rat:report> > > >>> > > >>> I hadn't even thought about that, but it's a nifty side effect. :) > > >>> > > >>>>> * Needed to add a new dependency (ant) to pick up TarInputStream > and > > >>>>> friends. > > >>>> > > >>>> For RAT's core commons-compress may be a better option, it is more > or > > >>>> less the same code base (for tar, zip and bzip2) and has a lighter > > >>>> footprint. Basically you'd have to change a few imports and class > > names > > >>>> (TarArchiveInputStream instead of TarInputStream). > > >>>> > > >>>> http://commons.apache.org/compress/ > > >>> > > >>> Thanks for the suggestion. I switched to commons-compress and > > uploaded a new version of the patch: > > https://issues.apache.org/jira/secure/attachment/12425235/rat-tar-gz- > > v2.patch > > >>> > > >>> Using commons-compress will actually make handling bz2 and zip files > > much easier, but I'm going to wait on those until this patch is > committed. > > >>> > > >>> Cheers, > > >>> -Hyrum > > >> > > > > > > > No virus found in this incoming message. > > Checked by AVG - www.avg.com > > Version: 9.0.709 / Virus Database: 270.14.99/2553 - Release Date: > 12/10/09 > > 05:41:00 > > No virus found in this incoming message. > Checked by AVG - www.avg.com > Version: 9.0.709 / Virus Database: 270.14.99/2553 - Release Date: 12/10/09 > 05:41:00
