On 2010-08-04, Hyrum Wright wrote: > In going through the codebase, I noticed a few areas among the > guessers that seemed a little verbose.
Agreed (I've never been looked at that code myself so far), maybe the code wanted to avid multiple exits from the methods? > The attached patch cleans them up a bit. Slightly modified version (added braces for one line ifs and I couldn't hold myself from simplifying one more line) went in as svn revision 982385. > Also, I'm a bit curious why we still require a source version of Java > 1.4. Not sure, my guess is that we didn't have a compelling reason to use Java5 features so far. There is a JIRA issue open that want to see us move to Java5. Stefan
