Hi Marvin, I've seen you've already sold your soul to buildbot 8-)
On 2011-03-14, Marvin Humphrey wrote: > On Mon, Mar 14, 2011 at 05:26:17PM +0100, Stefan Bodewig wrote: >> RAT creates a commons-io WildcardFileFilter from each exclude provided >> which behaves like Unix glob matchers (* and ? work like expected), >> except that they are applied to the children of a directory >> immediately. This means you can only match on the filename but not on >> its path. > Would it be acceptable to provide a patch for RAT which changes this > behavior to work on paths? Sure. > A couple different approaches are possible. > * Modify the interface for -e/--exclude > * Introduce a new command line flag. Unless you manage to implement the first one in a way that it still works the same for all old command line invocations (or all reasonable uses) I'd prefer the second. -E may be good. >>> For obvious reasons, it's not acceptable to exclude on filename or file >>> extension alone. >> But this is the only exclusion mechanism that is currently implemented >> inside the CLI, sorry. > Perhaps I just don't undertand the rationale, but to me, that seems like an > odd design. Apparently the Ant and Maven interfaces allow path-based > exclusions, so is the behavior of the CLI a bug? Honestly I don't know. I came to RAT as the initial author of the Ant task long after this and many other decisions have been made and never used the CLI myself. To me the current -e option looks as limiting as to you. Stefan
