Can we please make sure that all commits are, as far as possible, atomic. That is one functional change one commit.

This makes it much easier to review them and much easier to learn from them.

So, for example, don't mix a refactoring with a new feature. It takes a fair bit to check the 25 or so files touched in the login code addition to find the one or two files that actually implement the login feature.

(of course, I am don't want to be ungrateful for the work done, I'm just making a polite request that makes it easier to work in a large distributed team).

Thanks,
Ross

Reply via email to