[
https://issues.apache.org/jira/browse/RAVE-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051931#comment-13051931
]
Ate Douma edited comment on RAVE-78 at 6/20/11 11:15 AM:
---------------------------------------------------------
I checked the dependency tree where the Tomcat el-api was pulled in, and its
actually something we "cause" ourselves in the rave-shindig/pom.xml
The rave-shindig/pom.xml defines an unspecified (meaning: compile) scoped
dependency on the shindig-social-api. And this transitively pulls in
shindig-common which in turn pulls in Tomcat el-api and jasper-el dependencies.
As we already overlay the shindig-server war, which contains the
shindig-social-api, shindig-common, shindig-gadgets etc. dependencies there is
no need to overlay or repackage these of our own.
So, by simply specifying a scope provided on the shindig-api dependency already
"fixed" this issue.
I will also remove the shindig-gadgets dependency as we don't need that at all,
that is: at compile time.
(Note our current war overlay mechanism needs to be revisited in the future as
its not really resilient or extendable enough in the end, but that is
out-of-scope for this 0.1 release imo)
Of course, all this is still just a workaround for a bug in Shindig itself: it
shouldn't have compile-time dependencies on (Tomcat provided) el-api, nor the
jasper-el dependencies, as these always and only can/should be provided by the
container.
Furthermore, and another Shindig "bug" is that the current Shindig 3.0.0-beta2
has a dependency on the javax.servlet:jstl:1.2 jar (just in time...)
That dependency no longer exists, see: RAVE-66
So I expect that to break Shindig trunk pretty soon as well...
was (Author: adouma):
I checked the dependency tree where the Tomcat el-api was pulled in, and
its actually something we "cause" ourselves in the rave-shindig/pom.xml
The rave-shindig/pom.xml defines an unspecified (meaning: compile) scoped
dependency on the shindig-api. And this transitively pulls in shindig-common
which in turn pulls in Tomcat el-api and jasper-el dependencies.
As we already overlay the shindig-server war, which contains the shindig-api,
shindig-common, shindig-gadgets etc. dependencies there is no need to overlay
or repackage these of our own.
So, by simply specifying a scope provided on the shindig-api dependency already
"fixed" this issue.
I will also remove the shindig-gadgets dependency as we don't need that at all,
that is: at compile time.
(Note our current war overlay mechanism needs to be revisited in the future as
its not really resilient or extendable enough in the end, but that is
out-of-scope for this 0.1 release imo)
Of course, all this is still just a workaround for a bug in Shindig itself: it
shouldn't have compile-time dependencies on (Tomcat provided) el-api, nor the
jasper-el dependencies, as these always and only can/should be provided by the
container.
Furthermore, and another Shindig "bug" is that the current Shindig 3.0.0-beta2
has a dependency on the javax.servlet:jstl:1.2 jar (just in time...)
That dependency no longer exists, see: RAVE-66
So I expect that to break Shindig trunk pretty soon as well...
> rave-shindig incorrect dependency scope on shindig-social-api pulls in el-api
> jar breaking JSPs
> -----------------------------------------------------------------------------------------------
>
> Key: RAVE-78
> URL: https://issues.apache.org/jira/browse/RAVE-78
> Project: Rave
> Issue Type: Bug
> Affects Versions: 0.1-INCUBATING
> Reporter: Jasha Joachimsthal
> Assignee: Ate Douma
> Attachments:
> RAVE-78_Shindig_adds_a_el-api_jar_that_breaks_some_JSPs.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
